[compiler-rt] r327700 - tsan: revert: Update buildgo.sh to pass -isysroot on Darwin.

[Kuba Mracek via llvm-commits]

No problem. Specifying -isysroot is recommended and sometimes required on Darwin, because you can have multiple SDKs. If your change works for you, then that's okay, let me know if you see any failures. If I remember correctly, this was needed for machines that have both CommandLineTools and Xcode installed, but their versions differ.

If I need to put the -isysroot back, I'll make sure there's a fallback path (if xcodebuild -version returns an error, we'll just not use -isysroot).

Kuba

> On Mar 16, 2018, at 3:28 AM, Dmitry Vyukov <dvyukov at google.com> wrote:
> 
> Hi Kuba,
> 
> Sorry for submitting this without your ack, but I needed this unblock Go update.
> So why was that needed? Is it still needed? My build works without
> this part somehow. If it's still needed, how can we get around the
> error?
> 
> 
> On Fri, Mar 16, 2018 at 1:20 PM, Dmitry Vyukov via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: dvyukov
>> Date: Fri Mar 16 03:20:58 2018
>> New Revision: 327700
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=327700&view=rev
>> Log:
>> tsan: revert: Update buildgo.sh to pass -isysroot on Darwin.
>> 
>> This commit breaks actual Go runtime build on gomote builders (10.12) with:
>> 
>> xcode-select: error: tool 'xcodebuild' requires Xcode,
>> but active developer directory '/Library/Developer/CommandLineTools'
>> is a command line tools instance
>> 
>> Without this part build works fine.
>> The original commit does not include any explanation as to why
>> it is needed.
>> 
>> 
>> Modified:
>>    compiler-rt/trunk/lib/tsan/go/buildgo.sh
>> 
>> Modified: compiler-rt/trunk/lib/tsan/go/buildgo.sh
>> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/go/buildgo.sh?rev=327700&r1=327699&r2=327700&view=diff
>> ==============================================================================
>> --- compiler-rt/trunk/lib/tsan/go/buildgo.sh (original)
>> +++ compiler-rt/trunk/lib/tsan/go/buildgo.sh Fri Mar 16 03:20:58 2018
>> @@ -85,7 +85,7 @@ elif [ "`uname -a | grep NetBSD`" != ""
>>        "
>> elif [ "`uname -a | grep Darwin`" != "" ]; then
>>        SUFFIX="darwin_amd64"
>> -       OSCFLAGS="-fPIC -Wno-unused-const-variable -Wno-unknown-warning-option -isysroot $(xcodebuild -version -sdk macosx Path) -mmacosx-version-min=10.7"
>> +       OSCFLAGS="-fPIC -Wno-unused-const-variable -Wno-unknown-warning-option -mmacosx-version-min=10.7"
>>        OSLDFLAGS="-lpthread -fPIC -fpie -mmacosx-version-min=10.7"
>>        SRCS="
>>                $SRCS
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits