[PATCH] D44515: [IRCE] Change min value safety check

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 16 05:18:54 PDT 2018


fhahn added inline comments.


================
Comment at: lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:713
 
+static bool LoopGuardedAgainstMin(Loop *L, ScalarEvolution &SE, const SCEV *S,
+                                  bool Signed) {
----------------
mkazantsev wrote:
> I would suggest calling it `CannotBeMinInLoop` and reorder args like `S, L, Signed, SE`.
Maybe there's a more descriptive name for `S`,  e.g. `BoundSCEV` or something. 


https://reviews.llvm.org/D44515





More information about the llvm-commits mailing list