[PATCH] D44519: Add llvm-exegesis tool.
Kristof Beyls via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 16 03:09:39 PDT 2018
kristof.beyls added a comment.
Thanks for sharing this - this looks like a really promising tool.
I wonder if you have thought about adding unit/regression tests? Having them would make it quite a bit easier for others to contribute to its development.
Off the top of my head - to be able to unit/regression test this, you'd need a mock/fake "libpfm-like" implementation to make the test not rely on the results coming from whatever machine you're running on?
If that's a direction you want to take, designing that in earlier may be easier than retrofitting it in later?
================
Comment at: tools/llvm-exegesis/README.txt:1
+A
----------------
A README file doesn't seem necessary given llvm-exegesis.rst exists?
Repository:
rL LLVM
https://reviews.llvm.org/D44519
More information about the llvm-commits
mailing list