[PATCH] D44469: [llvm-readobj] - Teach llvm-readobj to dump .note.gnu.property sections.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 16 03:06:29 PDT 2018
grimar added inline comments.
================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3490
+ if (Data.size() >= sizeof(typename ELFT::uint)) {
+ uint64_t StackSize = ELFT::Is64Bits
+ ? support::endian::read64(Data.data(), E)
----------------
espindola wrote:
> Since this function is templated on ELFT I think you can just used ELFT::Addr:
>
> uint64_t StackSize = *(ELFT::Addr*)Data.data();
>
Yes, you're right, thanks.
https://reviews.llvm.org/D44469
More information about the llvm-commits
mailing list