[PATCH] D44464: OptBisect is improved to be overridden in LLVMContext

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

In https://reviews.llvm.org/D44464#1039734, @yrouban wrote:

> In https://reviews.llvm.org/D44464#1039293, @fedor.sergeev wrote:
>
> > Is it a matter of properly wording commit message?
>
>
> I think that the class name OptBisect is a bit misleading. The word //Bisect// explains just one way of using the skip functionality. I would change to something like //OptPassGate//, meaning that the class just decides if the pass should be skipped or run.


This suggestion is kinda in line with my first suggestion on generalization - introduce a base class OptPassGate, and derive OptBisect from it; routines that skip the passes should operate with OptPassGate, not with OptBisect directly.


https://reviews.llvm.org/D44464