[PATCH] D44184: Write DWARF data into WASM object file

Yury Delendik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 15 18:36:32 PDT 2018


yurydelendik marked 3 inline comments as done.
yurydelendik added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:1062
+	  RelEntry.Symbol = FuncSymbols[&Section];
+	  RelEntry.Addend += Section.getSectionOffset();
+	  break;
----------------
dschuff wrote:
> What is the section offset in this case? Are we just stuffing the offset from the beginning of the function in there?
> Are we just stuffing the offset from the beginning of the function in there

That's correct -- added this in a comment


Repository:
  rL LLVM

https://reviews.llvm.org/D44184





More information about the llvm-commits mailing list