[PATCH] D43361: [ThinLTO] Enable AutoHide on symbols with local_unnamed_addr

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

> I am tempered to just document in the language reference that it is invalid for a pass to drop local_unnamed_addr. With that the linker job is even simpler, it doesn't need to check the LTO produced files, just canBeOmittedFromSymbolTable in very IR symbol table.
> 
> Peter, what do you think?

I agree. If a pass drops local_unnamed_addr from a global, it means that the pass has changed the program semantics such that the global's address is significant. But passes are not allowed to change semantics, therefore dropping local_unnamed_addr is invalid.


Repository:
  rL LLVM

https://reviews.llvm.org/D43361