[PATCH] D44184: Write DWARF data into WASM object file

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: include/llvm/Object/Wasm.h:264
   std::vector<wasm::WasmFunctionName> DebugNames;
+  std::unordered_set<std::string> InternedNames;
   uint32_t StartFunction = -1;
----------------
This could probably be `llvm::StringSet`


================
Comment at: lib/MC/WasmObjectWriter.cpp:1059
+        case wasm::R_WEBASSEMBLY_FUNCTION_OFFSET_I32: {
+	  assert(RelEntry.hasAddend());
+	  auto& Section = static_cast<MCSectionWasm&>(RelEntry.Symbol->getSection());
----------------
should this be indented?


================
Comment at: lib/MC/WasmObjectWriter.cpp:1062
+	  RelEntry.Symbol = FuncSymbols[&Section];
+	  RelEntry.Addend += Section.getSectionOffset();
+	  break;
----------------
What is the section offset in this case? Are we just stuffing the offset from the beginning of the function in there?


Repository:
  rL LLVM

https://reviews.llvm.org/D44184