[PATCH] D44508: Remove unnecessary include from Driver.cpp
Frederich Munch via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 15 14:21:36 PDT 2018
marsupial added a comment.
Shouldn't the Translation Unit be responsible for knowing what it needs rather than hoping it's already been used somewhere up the chain.
Perhaps std::unique_ptr and std::make_pair are too low level and one can assume, but https://reviews.llvm.org/D44509 seems like a possibly overzealous application?
Repository:
rL LLVM
https://reviews.llvm.org/D44508
More information about the llvm-commits
mailing list