[PATCH] D44184: Write DWARF data into WASM object file

[Yury Delendik via Phabricator via llvm-commits]

yurydelendik added inline comments.


================
Comment at: include/llvm/BinaryFormat/Wasm.h:155
     // space.
     uint32_t ElementIndex;
     // For a data symbols, the address of the data relative to segment.
----------------
sbc100 wrote:
> Could we just use the the section index here and reuse the existing ElementIndex?   (Or at last move the Section inside the union?)
> at last move the Section inside the union?

I moved it here due to compiler complaining about StringRef not being a trivial type.


Repository:
  rL LLVM

https://reviews.llvm.org/D44184