[PATCH] D44490: [AArch64] Implement getArithmeticReductionCost

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 15 06:59:30 PDT 2018


mssimpso added a comment.

In https://reviews.llvm.org/D44490#1038465, @samparker wrote:

> I'm happy to see this! LGTM with just one small comment, no need to re-review. Thanks!


Thanks, Sam!



================
Comment at: lib/Target/AArch64/AArch64TargetTransformInfo.cpp:911
+
+  return BaseT::getArithmeticReductionCost(Opcode, ValTy, IsPairwise);
+}
----------------
samparker wrote:
> You could perform the IsPairwise check at the beginning of the function to exit early.
Yes, will do!


Repository:
  rL LLVM

https://reviews.llvm.org/D44490





More information about the llvm-commits mailing list