[PATCH] D44489: [TTI, AArch64] Allow the cost model analysis to test vector reduce intrinsics

[Matthew Simpson via Phabricator via llvm-commits]

mssimpso added a comment.

In https://reviews.llvm.org/D44489#1037919, @rengolin wrote:

> Hi Mathew,
>
> Why can't this be an extension of `getIntrinsicInstrCost` itself? It already has that logic (and much more)...
>
> Also, my comments are related to further extensions of this function (if necessary), as well as for extending `getIntrinsicInstrCost`.
>
> I fear we'll end up with a big list of lambdas before the actual switches, all to wrap common variables and safety asserts.
>
> cheers,
> --renato


Thanks a lot for taking a look at the patch, Renato! Ah, I missed the implementation of getIntrinsicInstrCost over in BasicTTIImpl.h. I agree - it definitely makes sense to move this logic there. I'll update the patch with your suggestions.


Repository:
  rL LLVM

https://reviews.llvm.org/D44489