[PATCH] D44291: [ARM, AArch64] Check the no-stack-arg-probe attribute for dynamic stack probes

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:7530
 
+  if (DAG.getMachineFunction().getFunction().hasFnAttribute(
+          "no-stack-arg-probe")) {
----------------
This is unfortunate, ideally we could fall back to Expand here.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:7537
+    SDValue Ops[2] = {SP, Chain};
+    return DAG.getMergeValues(Ops, dl);
+  }
----------------
What about the alignment?


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:13959
+    Chain = DAG.getCopyToReg(Chain, DL, ARM::SP, SP);
+    SDValue Ops[2] = { SP, Chain };
+    return DAG.getMergeValues(Ops, DL);
----------------
Alignment again?


https://reviews.llvm.org/D44291