[lld] r327613 - [ELF] - Fix build bot after rL327612.

Eric Liu via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 15 02:46:42 PDT 2018


Thanks again for the quick fix George!

On Thu, Mar 15, 2018 at 10:38 AM George Rimar <grimar at accesssoftek.com>
wrote:

> ​Hi Eric,
>
>
> Looks I missed one more place. Will commit in a minute. Sorry for
> inconvinence.
>
>
> Best regards,
> George | Developer | Access Softek, Inc
> ------------------------------
> *От:* Eric Liu <ioeric at google.com>
> *Отправлено:* 15 марта 2018 г. 12:36
> *Кому:* George Rimar
> *Копия:* llvm-commits at lists.llvm.org
> *Тема:* Re: [lld] r327613 - [ELF] - Fix build bot after rL327612.
>
> Hi George,
>
> Thanks for fixing this. I'm still seeing build warnings for this. Could
> you please take a look? Thanks!
>
> llvm/tools/lld/ELF/LinkerScript.h:194:32: error: field 'Expression' will
> be initialized after field 'CommandString' [-Werror,-Wreorder]
>
> On Thu, Mar 15, 2018 at 10:27 AM George Rimar via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: grimar
>> Date: Thu Mar 15 02:24:51 2018
>> New Revision: 327613
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=327613&view=rev
>> Log:
>> [ELF] - Fix build bot after rL327612.
>>
>> Error was:
>> error: field 'Size' will be initialized after field 'CommandString'
>> [-Werror,-Wreorder]
>>
>> Modified:
>>     lld/trunk/ELF/LinkerScript.h
>>
>> Modified: lld/trunk/ELF/LinkerScript.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.h?rev=327613&r1=327612&r2=327613&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/ELF/LinkerScript.h (original)
>> +++ lld/trunk/ELF/LinkerScript.h Thu Mar 15 02:24:51 2018
>> @@ -191,8 +191,8 @@ struct AssertCommand : BaseCommand {
>>  // Represents BYTE(), SHORT(), LONG(), or QUAD().
>>  struct ByteCommand : BaseCommand {
>>    ByteCommand(Expr E, unsigned Size, std::string CommandString)
>> -      : BaseCommand(ByteKind), Expression(E), Size(Size),
>> -        CommandString(CommandString) {}
>> +      : BaseCommand(ByteKind), Expression(E),
>> CommandString(CommandString),
>> +        Size(Size) {}
>>
>>    static bool classof(const BaseCommand *C) { return C->Kind ==
>> ByteKind; }
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180315/ece24a61/attachment.html>


More information about the llvm-commits mailing list