[PATCH] D39063: Fix for PR32990.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

I ended up putting together a patch that attempts to solve this issue: https://reviews.llvm.org/D44505
Does that cover all the cases here? I think we already have test for a lot of them in tree.



================
Comment at: lib/CodeGen/CodeGenModule.cpp:791
       // Don't dllexport/import destructor thunks.
-      GV->setDLLStorageClass(llvm::GlobalValue::DefaultStorageClass);
-      return;
+      //GV->setDLLStorageClass(llvm::GlobalValue::DefaultStorageClass);
+      switch (GD.getDtorType()) {
----------------
There is still commented out code and the indentation seems off.


================
Comment at: lib/CodeGen/CodeGenModule.cpp:793
+      switch (GD.getDtorType()) {
+      case CXXDtorType::Dtor_Base:
+      case CXXDtorType::Dtor_Deleting: {
----------------
This doesn't seem right, since we definitely want to export base destructors (??1Foo at ...).


https://reviews.llvm.org/D39063