[PATCH] D44467: [ARM] Convert more invalid NEON immediate loads

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 14 15:40:47 PDT 2018


rengolin added a comment.

Nice cleanup!

The patch is looking really good. I think you can just rename `vmov-vmvn-byte-replicate.s` to `vmov-vmvn-replicate.s` and put all the tests together.

Just make sure you have the same number of check lines as you have tests and it should be good to go, thanks!



================
Comment at: test/MC/ARM/vmov-vmvn-byte-replicate.s:28
+        vmov.i64        d2, #0xabababababababab
+        vmov.i64        q2, #0xabababababababab
         vmov.i32        d2, #0xabababab
----------------
Didn't add check lies for those


================
Comment at: test/MC/ARM/vmov-vmvn-byte-replicate.s:39
+        vmvn.i64        d2, #0xabababababababab
+        vmvn.i64        q2, #0xabababababababab
         vmvn.i32        d2, #0xabababab
----------------
or those


https://reviews.llvm.org/D44467





More information about the llvm-commits mailing list