[PATCH] D44349: [WebAssembly] Verify contents of relocations target before writing it

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

> The motivating reason is that we are thinking of adding linker relaxation for accessing external global addresses. I was speaking to @mcgrathr about this and he said that the linker (in this case at least) can/should/does check for sanity of the surrounding instructions before replacing/modifying it. So I'd also be OK only doing this when we do relaxation perhaps?

Maybe. If you already have some piece of data when processing something, and you can easily use that data to verify something, you probably should do that. But I don't think we do some extra validation for the sake of validation. In particular, creating a map and look it up for each relocation just for validation is too expensive and doesn't feel lld-ish.


Repository:
  rL LLVM

https://reviews.llvm.org/D44349