[PATCH] D44168: [ELF] Add .eh_frame pieces to map file

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/MapFile.cpp:143
+  for (EhSectionPiece &P : Pieces) {
+    writeHeader(OS, OSec->Addr + P.OutputOff, P.Size, 0);
+    OS << indent(1) << toString(P.Sec->File) << ":(" << P.Sec->Name << "+0x"
----------------
andrewng wrote:
> Perhaps instead of 0 for the alignment, this could be the EhSectionPiece alignment which is Config->Wordsize?
I actually don't think so -- I believe the section itself is aligned, but each piece within a section doesn't have a notion of alignment.


https://reviews.llvm.org/D44168