[PATCH] D44415: [PM][FunctionAttrs] add NoUnwind attribute inference to PostOrderFunctionAttrs pass

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

Thanks everybody for good comments, will see into them.
Will put virtual functions issue at the very end of the queue.

In https://reviews.llvm.org/D44415#1036829, @jlebar wrote:

> - Is it possible to explain in the code itself everything a user needs to know to understand the code?  For example, I could not find where we define "derefinable", or derefinement.


I'm not sure about proper usage of this term either. It came from my discussions with Chandler, but if it sounds confusing ....
Anyway, I tried to explain the term in my commit message.

>   More broadly, it is not easy for me to follow the overall structure of this code just by reading the code.

You mean overall structure of AttributeInferer::run?

> - It's a nit, but I would prefer to write all comments in proper English, so starting with capital letters, ending with periods

Yeah, it is my biggest common mistake with the style :-/


Repository:
  rL LLVM

https://reviews.llvm.org/D44415