[PATCH] D44388: [ELF] Rework debug line parsing to use llvm::Error (LLD-side)

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:127
   // CU (object file), so offset is always 0.
-  const DWARFDebugLine::LineTable *LT =
-      DwarfLine->getOrParseLineTable(LineData, 0, Dwarf, nullptr);
+  auto LTOrErr = DwarfLine->getOrParseLineTable(LineData, 0, Dwarf, nullptr);
+  const DWARFDebugLine::LineTable *LT = LTOrErr.Table;
----------------
I agree with David; LTOrError is a confusing variable name.

Can you avoid using `auto` here?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44388