[PATCH] D44453: Update Error Message

[Rumeet Dhindsa via Phabricator via llvm-commits]

rdhindsa added inline comments.


================
Comment at: test/ELF/aarch64-fpic-add_abs_lo12_nc.s:4
 // RUN: not ld.lld -shared %t.o -o %t.so 2>&1 | FileCheck %s
-// CHECK: can't create dynamic relocation R_AARCH64_ADD_ABS_LO12_NC against symbol: dat
+// CHECK: can't create dynamic relocation R_AARCH64_ADD_ABS_LO12_NC against symbol: dat in readonly segment; recompile object files with -fPIC to not create such relocations or pass "-z notext" to allow text relocations for lld
 // CHECK: >>> defined in {{.*}}.o
----------------
ruiu wrote:
> I think you need to update this test as well. (Your C++ code recommends -Wl,-z,notext but this error message mentions "-z notext".
Done! Sorry, I missed it earlier.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44453