[PATCH] D44292: [LLD] [COFF, MinGW] Implement the GNU ld flag --kill-at

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 14 12:23:19 PDT 2018


rnk added inline comments.


================
Comment at: test/COFF/def-export-stdcall.s:75
+# MINGW-KILL-AT-IMPLIB-NEXT: __imp__stdcall
+# MINGW-KILL-AT-IMPLIB-NEXT: _stdcall
+
----------------
mstorsjo wrote:
> rnk wrote:
> > We might as well test vectorcall for completeness.
> GCC doesn't support vectorcall, so there's no reference on how it should behave with that.
Sure, but the code you wrote seems like it will apply to vectorcall, so we have some emergent behavior in this corner case and we should validate that it stays the same over time.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44292





More information about the llvm-commits mailing list