[PATCH] D44464: OptBisect is improved to be overridden in LLVMContext

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added a comment.

I have some concerns about this patch, mostly  centered around what the intended use cases are.

Compiling in multiple threads probably isn't handled well with the current implementation (i.e. prior to this patch) but having different instances of the OptBisect object for each thread may not fix it. For the opt bisect process to work, individual optimizations need to call OptBisect::checkPass() in a deterministic order. I would think it's probably best to just avoid multi-threaded compilation when using OptBisect.

Maybe if I knew what is motivating this change it would make more sense to me.


https://reviews.llvm.org/D44464