[PATCH] D44475: TableGen: Check the dynamic type of !cast<Rec>(string)

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 14 11:42:28 PDT 2018


tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/llvm/TableGen/Record.h:1795
 public:
   explicit Resolver(Record *CurRec) : CurRec(CurRec) {}
   virtual ~Resolver() {}
----------------
I'd remove setFinal() and make isFinal a constructor parameter. Up to you.


Repository:
  rL LLVM

https://reviews.llvm.org/D44475





More information about the llvm-commits mailing list