[PATCH] D44425: [InstSimplify] peek through unsigned FP casts for sign-bit compares (PR36682)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D44425#1037229, @lebedev.ri wrote:

> Rebased ontop of updated tests, moved to InstSimplify.
>  FIXME: should that code be in some other place, in some other function?


simplifyICmpWithConstant()? I think you'd have to put it above the m_APInt() check in that function in order to still get some of the vector tests with undef elements though.



================
Comment at: test/Transforms/InstSimplify/cast-unsigned-icmp-cmp-0.ll:4
 
 ; target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
 
----------------
Please remove the datalayout comment.


================
Comment at: test/Transforms/InstSimplify/cast-unsigned-icmp-cmp-0.ll:8
 
 ; FIXME: All of these can be simplified to a constant true or false value.
 ;   * slt i32 %b, 0  -> false
----------------
Remove the 'FIXME' part of this.


================
Comment at: test/Transforms/InstSimplify/cast-unsigned-icmp-cmp-0.ll:12
 
+; FIXME: icmp slt does not handle undef elements in vectors.
+
----------------
This should be "m_Zero does not handle undef elements in vectors."


Repository:
  rL LLVM

https://reviews.llvm.org/D44425