[PATCH] D44419: [SCEV][NFC] Remove TBB, FBB parameters from exit limit computations

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: include/llvm/Analysis/ScalarEvolution.h:1436
   /// execute if its exit condition were a conditional branch of ExitCond,
-  /// TBB, and FBB.
+  /// and ExitByCond.
   ///
----------------
Not sure what this comment means anymore.  Let's rename `ExitByCond` to `ExitOnTrue`.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:7019
       // Recurse on the operands of the and.
-      bool EitherMayExit = L->contains(TBB);
       ExitLimit EL0 = computeExitLimitFromCondCached(
----------------
Let's keep this as `bool EitherMayExit = !ExitOnTrue` -- it is useful documentation.


https://reviews.llvm.org/D44419