[PATCH] D42728: Add more warnings for implict conversions (e.g. double truncation to float).

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:8623-8625
+static void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
+                                    SourceLocation CC,
+                                    bool *ICContext = nullptr);
----------------
Do you really need this declaration here?


================
Comment at: lib/Sema/SemaChecking.cpp:9527
+static void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
+                                    SourceLocation CC, bool *ICContext) {
   if (E->isTypeDependent() || E->isValueDependent()) return;
----------------
ABataev wrote:
> DO you still need `ICContext` parameter? I don't see where it is used.
Hmm, seems to me you just reformatted the code. Restore the original code.


https://reviews.llvm.org/D42728