[PATCH] D44316: [WebAssembly] Demangle symbol names for use by the browser debugger
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 14 10:38:43 PDT 2018
sbc100 added a comment.
Hmm.. its kind of shame maybe that we decided to demangle the names in the name section as they no longer match the symbol table names.
If we want to stick with the decision than maybe we should move to having libObject completely ignore the name section. For example, all of the native tooling expects symbol names to be mangled with the option to de-mangle them (think `nm` vs `nm -C`).
Anyway, I think all internal names and symbols should be mangled and valid C identifiers. Demangling things should be reserved for the moment of displaying. For this reason I think we should either reverse our decision to store demangled names in the name section, or ignore the name section when it comes to naming things internally and rely on the symbol table instead.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D44316
More information about the llvm-commits
mailing list