[PATCH] D44292: [LLD] [COFF, MinGW] Implement the GNU ld flag --kill-at

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: COFF/DriverUtils.cpp:586
+// Convert stdcall/fastcall style symbols into unsuffixed symbols,
+// with or without a leading underscore.
+static StringRef killAt(StringRef Sym, bool Prefix) {
----------------
Please also say that this is MinGW-specific.


================
Comment at: COFF/DriverUtils.cpp:592
+  Sym = Sym.substr(0, Sym.find('@', 1));
+  if (Sym.startswith("@")) {
+    // For fastcall, remove the leading @ and replace it with an
----------------
You can flip the condition to return early.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44292