[PATCH] D44421: [InstSimplify] [NFC] Add tests for peeking through unsigned FP casts for sign compares (PR36682)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 14 09:42:17 PDT 2018


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

Thanks - that's better coverage. LGTM.



================
Comment at: test/Transforms/InstSimplify/cast-unsigned-icmp-cmp-0.ll:8-9
+
+; FIXME: *all* of these are true tests.
+; *All* of these can be simplified to a boolean:
+;   * slt i32 %b, 0  -> false
----------------
The wording is confusing. I'd make this:
; FIXME: All of these can be simplified to a constant true or false value.


Repository:
  rL LLVM

https://reviews.llvm.org/D44421





More information about the llvm-commits mailing list