[PATCH] D44474: TableGen: Explicitly test some cases of self-references and !cast errors

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 14 08:21:13 PDT 2018


nhaehnle created this revision.
nhaehnle added reviewers: arsenm, craig.topper, tra, MartinO.
Herald added subscribers: kbarton, wdng, nemanjai.

These are cases of self-references that exist today in practice. Let's
add tests for them to avoid regressions.

The self-references in PPCInstrInfo.td can be expressed in a simpler
way. Allowing this type of self-reference while at the same time
consistently doing late-resolve even for self-references is problematic
because there are references to fields that aren't in any class. Since
there's no need for this type of self-reference anyway, let's just
remove it.

Change-Id: I914e0b3e1ae7adae33855fac409b536879bc3f62


Repository:
  rL LLVM

https://reviews.llvm.org/D44474

Files:
  lib/TableGen/Record.cpp
  lib/Target/PowerPC/PPCInstrInfo.td
  test/TableGen/cast-typeerror.td
  test/TableGen/self-reference-typeerror.td
  test/TableGen/self-reference.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44474.138364.patch
Type: text/x-patch
Size: 4498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180314/6eb90e23/attachment.bin>


More information about the llvm-commits mailing list