[PATCH] D44195: TableGen: Remove the cast-from-string-to-variable-reference feature

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

In https://reviews.llvm.org/D44195#1033009, @tra wrote:

> What happens now when someone attempts to cast a variable name?
>  Will the !cast remain unresolved or will we see a "symbol  X not found" error? Both would be somewhat confusing as that X may be something that is obviously there (e.g. template parameter). I'd rather see an explicit error telling me exactly what's wrong. Something like "!cast to a local symbol is not allowed".


You'd get an "Undefined reference: 'xxx'" error as if you were referencing a record that doesn't exist. I'm changing that to "Undefined reference to record" to be even more explicit about it.


Repository:
  rL LLVM

https://reviews.llvm.org/D44195