[PATCH] D44464: OptBisect is improved to be overridden in LLVMContext

[Eugene Zelenko via Phabricator via llvm-commits]

Eugene.Zelenko added inline comments.


================
Comment at: include/llvm/IR/OptBisect.h:39
 
+  virtual ~OptBisect() {}
+
----------------
Please use = default;


================
Comment at: lib/IR/LLVMContext.cpp:338
 }
+void LLVMContext::setOptBisect(OptBisect& OB) {
+  pImpl->setOptBisect(OB);
----------------
Please separate with empty line.


================
Comment at: lib/IR/LLVMContextImpl.cpp:43
+    Int128Ty(C, 128),
+    OptBisector(nullptr) {}
 
----------------
Please use default initialization instead.


================
Comment at: lib/IR/LLVMContextImpl.h:1358
 
+  OptBisect *OptBisector;
+
----------------
Please use default initialization, = nullptr


https://reviews.llvm.org/D44464