[PATCH] D44386: [x86] Introduce the pconfig/enclv instructions
Gabor Buella via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 14 03:48:47 PDT 2018
GBuella marked an inline comment as done.
GBuella added inline comments.
================
Comment at: utils/TableGen/X86RecognizableInstr.cpp:681
case X86Local::MRM_C0: case X86Local::MRM_C1: case X86Local::MRM_C2:
- case X86Local::MRM_C3: case X86Local::MRM_C4: case X86Local::MRM_C8:
- case X86Local::MRM_C9: case X86Local::MRM_CA: case X86Local::MRM_CB:
- case X86Local::MRM_CF: case X86Local::MRM_D0: case X86Local::MRM_D1:
- case X86Local::MRM_D4: case X86Local::MRM_D5: case X86Local::MRM_D6:
- case X86Local::MRM_D7: case X86Local::MRM_D8: case X86Local::MRM_D9:
- case X86Local::MRM_DA: case X86Local::MRM_DB: case X86Local::MRM_DC:
- case X86Local::MRM_DD: case X86Local::MRM_DE: case X86Local::MRM_DF:
- case X86Local::MRM_E0: case X86Local::MRM_E1: case X86Local::MRM_E2:
- case X86Local::MRM_E3: case X86Local::MRM_E4: case X86Local::MRM_E5:
- case X86Local::MRM_E8: case X86Local::MRM_E9: case X86Local::MRM_EA:
- case X86Local::MRM_EB: case X86Local::MRM_EC: case X86Local::MRM_ED:
- case X86Local::MRM_EE: case X86Local::MRM_EF: case X86Local::MRM_F0:
- case X86Local::MRM_F1: case X86Local::MRM_F2: case X86Local::MRM_F3:
- case X86Local::MRM_F4: case X86Local::MRM_F5: case X86Local::MRM_F6:
- case X86Local::MRM_F7: case X86Local::MRM_F9: case X86Local::MRM_FA:
- case X86Local::MRM_FB: case X86Local::MRM_FC: case X86Local::MRM_FD:
- case X86Local::MRM_FE: case X86Local::MRM_FF:
+ case X86Local::MRM_C3: case X86Local::MRM_C4: case X86Local::MRM_C5:
+ case X86Local::MRM_C8: case X86Local::MRM_C9: case X86Local::MRM_CA:
----------------
craig.topper wrote:
> We should just add all of C8-FF into this switch. They are all defined not sure why they aren't already here. I'll go ahead and do that ahead of this patch.
Thanks, I rebased it on top of your change.
https://reviews.llvm.org/D44386
More information about the llvm-commits
mailing list