[PATCH] D44407: [DebugInfo] Add a new method IPDBSession::findLineNumbersBySectOffset

[Zachary Turner via llvm-commits]

Ahh i see, maybe there is no way to avoid the duplication then. Still wish
I remembered why I did that, because now the code looks odd.

Anyway, lgtm
On Tue, Mar 13, 2018 at 9:24 PM Aaron Smith via Phabricator <
reviews at reviews.llvm.org> wrote:

> asmith added a comment.
>
> findLineNumbersByAddress() uses findLinesByVA/RVA and
> findSymbolByAddress() uses findSymbolByVA/RVA.
>
> Do you still want them factored out into two methods: findLinesByVAOrRVA
> and findSymbolByVAOrRVA?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D44407
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180314/3fabd4a4/attachment.html>