[PATCH] D44235: [LTO/gold] Support --wrap

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson reopened this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D44235#1036553, @pcc wrote:

> In https://reviews.llvm.org/D44235#1036549, @tejohnson wrote:
>
> > I had to revert as the new api is not available:
> >  http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/9109/steps/build-stage2-LLVMgold.so/logs/stdio
> >
> > What is the best way to handle this? I see that there are a couple defines at the top of gold-plugin.cpp for other newer LDPT_* types, so I could add LDPT_GET_WRAP_SYMBOLS there.
> >
> > For ld_plugin_get_wrap_symbols I guess I can add my own typedef at the top of gold-plugin.cpp?
>
>
> Sounds good. Of course, the `tv_get_wrap_symbols` field will not be present so you will need to cast one of the other fields.


Ugh, yeah that too. It's a little ugly, but I added FIXME comments in the various places to remove them when we require the binutils 2.31 (which would be the next version). I tested with both the old and new plugin-api.h to make sure it works with both now. I'll submit in the morning so that I can watch the bots.


Repository:
  rL LLVM

https://reviews.llvm.org/D44235