[PATCH] D44406: [CodeView] Emit HasConstructorOrDestructor class option

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1772
+      StringRef Name = Method->getName();
+      if (Name == Ty->getName() || (!Name.empty() && Name[0] == '~')) {
+        CO |= ClassOptions::HasConstructorOrDestructor;
----------------
Eventually I think we'll need to mark constructors with `FunctionOptions::Constructor`, so we might as well go ahead and claim a bit from DIFlags for it now and add `DISubprogram::isCXXConstructor`. We can add an `isCXXDestructor` method that does the `~` check for now, since that doesn't require looking at the containing class type.


Repository:
  rL LLVM

https://reviews.llvm.org/D44406