[PATCH] D43248: [Attr] Fix parameter indexing for attributes

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 12:58:10 PDT 2018


echristo added inline comments.


================
Comment at: test/Sema/attr-print.cpp:3
 
+// This file is also used as input for %S/../Frontend/ast-attr.cpp.
+
----------------
Relatedly I don't think we use files as input files to other directories and I don't think we should really. What are you trying to test here? This breaks the hermeticness of each particular test directory.


Repository:
  rC Clang

https://reviews.llvm.org/D43248





More information about the llvm-commits mailing list