[PATCH] D35430: DA: remove uses of GEP, only ask SCEV

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In https://reviews.llvm.org/D35430#1036137, @sebpop wrote:

> > Requiring assertions for the tests is not too bad, although I think it would be better to use optimization remarks, which should be available in release mode too.
>
> whenever it was possible to use -pass-remarks=loop-interchange I used that.
>  The loop interchange pass needs to output more diagnostic about why it failed to interchange when using -pass-remarks.
>  Then the tests can be moved back to not require asserts.


Yes, unfortunately there is lots of work to do...

> 
> 
>> But we definitely need at least some tests that check the actual IR, to make sure the actual transformation is performed (or not performed) and correct.
> 
> What about adding new correctness tests for loop interchange to the test-suite?

That's an excellent idea. I have a patch lying around somewhere and this should be enough motivation to submit it for review ;-)

I think we still need at least some tests checking interchanging is done correctly on the IR level. I'll look into cleaning the tests up in general.


Repository:
  rL LLVM

https://reviews.llvm.org/D35430