[PATCH] D44433: DWARFVerifier: Enhance validation of .debug_names hash tables

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 09:51:12 PDT 2018


aprantl added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:848
+  }
+
+  for (uint32_t Bucket = 0, End = NI.getBucketCount(); Bucket < End; ++Bucket) {
----------------
A few more comments on what is being checked wouldn't hurt.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:881
+    if (B.Bucket == NI.getBucketCount())
+      break; // sentinel
+
----------------
Can you turn this comment into a full sentence?


Repository:
  rL LLVM

https://reviews.llvm.org/D44433





More information about the llvm-commits mailing list