[PATCH] D44153: Build system changes for RISCV

[Azharuddin Mohammed via Phabricator via llvm-commits]

azharudd added a comment.

In https://reviews.llvm.org/D44153#1031969, @asb wrote:

> Hi Azharuddin, many thanks for the contribution. I hadn't spotted this part of LLVM's CMake build system, and it's definitely useful to be able to build just the RISCV backend. I've tried this locally, and the problem I'm seeing is that a good number of Clang and LLVM tests fail when you don't build X86 support. On my system, 351 unexpected failures across Clang+LLVM. This is a problem with the tests rather than this patch (they should really be disabled if there is no X86 support), but it does limit the usefulness of just building _only_ the RISC-V backend. Is it expected that you build an LLVM with X86 and RISCV, ensure 100% tests pass, then build with just the RISCV backend and ignore any new failures?
>
> The problems I'm seeing aren't introduced by this patch, so LGTM. I'd be curious on how/if you work around the tests issue though.


I don't see any additional failures with this change. It shouldn't cause any issues with existing builds. You are right -- it is a problem with the tests and not this patch. If there are any test failures when building just RISC-V -- particularly the target independent ones -- we'll have to fix RISC-V for those tests (we can ignore those failures for now). If there are any target specific tests requiring certain target, they should be marked as such.


Repository:
  rL LLVM

https://reviews.llvm.org/D44153