[PATCH] D44311: [WebAssembly] Implement -print-gc-sections to test global GC

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 09:29:35 PDT 2018


ncw updated this revision to Diff 138209.
ncw marked an inline comment as done.
ncw added a comment.

Updated: removed chunk from MarkLive, fixed conflicts on rebase.

Not sure how to resolve the discussion on this one... Rui suggested moving it to MarkLive to sit alongside the function GC, which I've done in https://reviews.llvm.org/D44313 rather than open that can of worms here. But Sam isn't too keen on that, and prefers doing global GC in a separate later pass, although the code for handling function/global GC looks essentially the same.

Really all this commit is trying to do is just add a simple test for global GC, and implement `--print-gc-sections` with the same behaviour as function GC, just so that the test output matches.

I had hoped to be able to merge this one without stirring up disagreement :( I'm sorry.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44311

Files:
  test/wasm/Inputs/globals.yaml
  test/wasm/gc-sections.ll
  wasm/Driver.cpp
  wasm/InputFiles.cpp
  wasm/InputGlobal.h
  wasm/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44311.138209.patch
Type: text/x-patch
Size: 10476 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180313/a9758adb/attachment.bin>


More information about the llvm-commits mailing list