[PATCH] D44356: [LICM] Salvage DebugInfo from dying Instructions

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Ah, I think there's still a problem with the test.



================
Comment at: test/Transforms/LICM/sinking.ll:254
+
+; DEBUGIFY-LABEL: @PR18753(
+; DEBUGIFY:    call void @llvm.dbg.value(metadata i32 %l.le, metadata {{.*}}, metadata !DIExpression())
----------------
The label to check for should be @test11


================
Comment at: test/Transforms/LICM/sinking.ll:255
+; DEBUGIFY-LABEL: @PR18753(
+; DEBUGIFY:    call void @llvm.dbg.value(metadata i32 %l.le, metadata {{.*}}, metadata !DIExpression())
 }
----------------
The dbg.value should look like: call void @llvm.dbg.value(metadata %Ty* @X2, metadata {{.*}}, metadata !DIExpression(DW_OP_stack_value))

If you run "check-llvm" after making this change, the tests should all pass.


Repository:
  rL LLVM

https://reviews.llvm.org/D44356