[PATCH] D44416: [InstCombine] [NFC] Add tests for peeking through unsigned FP casts for zero-equality compares (PR36682)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 06:39:59 PDT 2018


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - although I think it would be more useful and more compact to have 1 or 2 vector tests at the end with a zeroinitializer constant followed by 1 or 2 vector tests with an undef element in the constant. This will show that we already do support vector types; we're just lacking the last piece of the puzzle - discounting undef elements (and I'll try to fix that soon).

And as I said before, if we verify that at least one case works with vectors, then it's a good bet that all of these cases work with vectors.


Repository:
  rL LLVM

https://reviews.llvm.org/D44416





More information about the llvm-commits mailing list