[PATCH] D44309: [llvm-mca] Refactor event listeners to make the backend agnostic to event types.

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 03:29:31 PDT 2018


andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.

Thanks Clement!

I only have one minor nit. Otherwise, the patch looks good to me.

-Andrea



================
Comment at: tools/llvm-mca/HWEventListener.h:64
+  HWInstructionIssuedEvent(unsigned Index,
+                           llvm::ArrayRef<std::pair<ResourceRef, unsigned>> UR)
+      : HWInstructionEvent(HWInstructionEvent::Issued, Index),
----------------
UR should be a const ArrayRef.


Repository:
  rL LLVM

https://reviews.llvm.org/D44309





More information about the llvm-commits mailing list