[PATCH] D44367: [InstCombine] peek through FP casts for sign-bit compares (PR36682)
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 12 13:45:41 PDT 2018
lebedev.ri added a comment.
In https://reviews.llvm.org/D44367#1035270, @spatel wrote:
> Patch updated:
> This is only a rebase with the new tests from https://reviews.llvm.org/rL327301 and deleting the redundant ones.
Thanks, looks like a start!
> Should we handle x < 1, x > 0, x == 0, and x != 0 in this patch too?
Those don't really match the differential's subject, i'd say they should be in the next one[s].
(I suppose i can implement those cases now that there is an example :))
https://reviews.llvm.org/D44367
More information about the llvm-commits
mailing list