[PATCH] D44401: [AMDGPU] Always use IDX for load/store format intrinsics.

[Bas Nieuwenhuizen via Phabricator via llvm-commits]

bnieuwenhuizen created this revision.
bnieuwenhuizen added reviewers: arsenm, nhaehnle, mareko.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, wdng, kzhuravl.

On Vega, whether the buffer size in the descriptor is interpreted
in bytes or in units of stride depends on whether IDXEN is enabled.

This modifies the format intrinsics to always use IDXEN for GFX9,
so that we can always rely on it being units of stride. Before this
the intrinsics were pretty much unusable as we cannot fill in the
size field without knowing if LLVM will apply the optimization.

I heard people on IRC that they preferred modifying the existing
intrinsic. If you want me to create new ones for the pattern, that
is OK with me.


Repository:
  rL LLVM

https://reviews.llvm.org/D44401

Files:
  lib/Target/AMDGPU/AMDGPU.td
  lib/Target/AMDGPU/BUFInstructions.td
  test/CodeGen/AMDGPU/llvm.amdgcn.buffer.load.format.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44401.138089.patch
Type: text/x-patch
Size: 12327 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180312/df3e9c20/attachment.bin>