[PATCH] D44086: [LLVM-C] [bindings/go] Add C and Golang bindings for COMDAT
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 12 12:06:08 PDT 2018
rnk added a comment.
One issue, looks good otherwise. I don't know Go but it seems straightforward.
================
Comment at: include/llvm-c/Comdat.h:24
+typedef enum {
+ LLVMAnyComdatSelectionKind, ///< The linker may choose any COMDAT.
+ LLVMExactMatchComdatSelectionKind, ///< The data referenced by the COMDAT must
----------------
These should probably have explicit enumerator values so that they do not change over time.
Repository:
rL LLVM
https://reviews.llvm.org/D44086
More information about the llvm-commits
mailing list