[PATCH] D44382: [DWARF] Rework debug line parsing to use llvm::Error

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

Hi James,

First off, thanks for working on this! Unfortunately I didn't get around to reviewing this today. As a general note, like Pavel already said, this isn't really idiomatic when it comes to the Error class. The `None` severity doesn't make sense (you could always return an `Optional<Severity>` where necessary) but I don't have a good solution in mind when it comes to surfacing the other kind of errors. I'll have a more in-depth look tomorrow to better understand the constraints.


Repository:
  rL LLVM

https://reviews.llvm.org/D44382