[PATCH] D43795: [New PM][IRCE] port of Inductive Range Check Elimination pass to the new pass manager

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

Not familiar with the details here, adding a couple of formatting nits.



================
Comment at: include/llvm/Transforms/Scalar/LoopPassManager.h:307
+                                       MSSA,
+                                       BPI};
 
----------------
clang-format?


================
Comment at: lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:45
 //===----------------------------------------------------------------------===//
-
+#include "llvm/Transforms/Scalar/InductiveRangeCheckElimination.h"
 #include "llvm/ADT/APInt.h"
----------------
Alphabetical order of includes?


================
Comment at: lib/Transforms/Scalar/LoopDistribute.cpp:998
       [&](Loop &L) -> const LoopAccessInfo & {
-    LoopStandardAnalysisResults AR = {AA, AC, DT, LI, SE, TLI, TTI, nullptr};
+    LoopStandardAnalysisResults AR = {AA,  AC,  DT,      LI,     SE,
+                                      TLI, TTI, nullptr, nullptr};
----------------
clang-format (whole patch)


Repository:
  rL LLVM

https://reviews.llvm.org/D43795